Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common): normalize ingress paths earlier #29817

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

stavros-k
Copy link
Collaborator

Description

⚒️ Fixes #

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning
  • I made sure the title starts with feat(chart-name):, fix(chart-name): or chore(chart-name):

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@stavros-k
Copy link
Collaborator Author

stavros-k commented Dec 9, 2024

Homepage integration was depending on the paths.
If none provided, while ingress would use default ones, homepage would not.

I now normalize the paths earlier, so homepage has paths to work with

Copy link

github-actions bot commented Dec 9, 2024

✅ Deploy Preview ready!

Name Link
🔨 Latest commit 318155d
🔍 Latest deploy log https://github.com/truecharts/public/actions/runs/12244917380
😎 Deploy Preview Url
🌳 Environment

@PrivatePuffin
Copy link
Member

Homepage integration was depending on the paths. If none provided, while ingress would use default ones, homepage would not.

I now normalize the paths earlier, so homepage has paths to work with

good catch!

@PrivatePuffin PrivatePuffin merged commit 7ea9dcf into master Dec 10, 2024
106 checks passed
@PrivatePuffin PrivatePuffin deleted the normalize-paths branch December 10, 2024 12:29
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants