Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(oscam) update version and add custom versioning #29800

Merged
merged 3 commits into from
Nov 30, 2024

Conversation

gismo2004
Copy link
Contributor

Description
switch oscam image to latest

⚒️ Fixes #

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning
  • I made sure the title starts with feat(chart-name):, fix(chart-name): or chore(chart-name):

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@alfi0812
Copy link
Collaborator

Please use a real version tag whenever possible. We try to avoid latest whenever possible

@gismo2004
Copy link
Contributor Author

@alfi0812 since oscam versioning does not follow semver and the xxx-lsxxx of linuxserver seems to be also not handled by renovate, I thought to switch it to latest for getting automatic image updates. And I honestly don't know how to separate oscam version numbers like '11719' or '11856' into major/minor/patch for a regex in customVersioning.json5 as it is just an increasing number for tags.

@kqmaverick
Copy link
Collaborator

Better way to fix this is updating the renovate rules so that updates are fetched properly.

https://github.com/truecharts/public/blob/master/.github/renovate/special/customVersioning.json5

@gismo2004
Copy link
Contributor Author

I agree but I don't know how, as I said before...

@kqmaverick
Copy link
Collaborator

Looks like 1.18.56 to me.

@gismo2004
Copy link
Contributor Author

Looks like 1.18.56 to me.

No it's not. It's just an increasing number as I also mentioned before.

https://git.streamboard.tv/common/oscam/-/commits/master

@kqmaverick
Copy link
Collaborator

Then just have it use that as the version and drop the -ls75

@gismo2004
Copy link
Contributor Author

Then just have it use that as the version and drop the -ls75

OK, then I will switch it to the 'version-x' variant as this is also available if you agree?

@gismo2004 gismo2004 requested a review from stavros-k as a code owner November 29, 2024 19:01
@gismo2004 gismo2004 changed the title chore(oscam) switch image to latest chore(oscam) update version and add loose versioning for renovate Nov 29, 2024
Copy link
Collaborator

@stavros-k stavros-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use 11856-ls125

It should work much better (I think)

A regex matching will be fine

break it like this
1 major 18 minor 56 patch ls125 build
https://docs.renovatebot.com/modules/versioning/regex/#description

I should at least pick updates.

@gismo2004
Copy link
Contributor Author

@stavros-k I updated according to your suggestion, BUT could you please elaborate why this is better compared to use loose or latest?

Fun fact: in ~735 stable charts, there are ~300 latest tags

@gismo2004 gismo2004 changed the title chore(oscam) update version and add loose versioning for renovate chore(oscam) update version and add custom versioning Nov 30, 2024
@stavros-k
Copy link
Collaborator

@stavros-k I updated according to your suggestion, BUT could you please elaborate why this is better compared to use loose or latest?

I like explicitly defined. What does loose even do? :D

Fun fact: in ~735 stable charts, there are ~300 latest tags

If you find one and upstream HAS a versioned tag, we are all in to make it tagged.

@stavros-k stavros-k merged commit 4b62963 into truecharts:master Nov 30, 2024
27 checks passed
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants