-
-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(oscam) update version and add custom versioning #29800
Conversation
Please use a real version tag whenever possible. We try to avoid latest whenever possible |
@alfi0812 since oscam versioning does not follow semver and the xxx-lsxxx of linuxserver seems to be also not handled by renovate, I thought to switch it to latest for getting automatic image updates. And I honestly don't know how to separate oscam version numbers like '11719' or '11856' into major/minor/patch for a regex in customVersioning.json5 as it is just an increasing number for tags. |
Better way to fix this is updating the renovate rules so that updates are fetched properly. https://github.com/truecharts/public/blob/master/.github/renovate/special/customVersioning.json5 |
I agree but I don't know how, as I said before... |
Looks like 1.18.56 to me. |
No it's not. It's just an increasing number as I also mentioned before. |
Then just have it use that as the version and drop the |
OK, then I will switch it to the 'version-x' variant as this is also available if you agree? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use 11856-ls125
It should work much better (I think)
A regex matching will be fine
break it like this
1 major 18 minor 56 patch ls125 build
https://docs.renovatebot.com/modules/versioning/regex/#description
I should at least pick updates.
@stavros-k I updated according to your suggestion, BUT could you please elaborate why this is better compared to use loose or latest? Fun fact: in ~735 stable charts, there are ~300 latest tags |
I like explicitly defined. What does
If you find one and upstream HAS a versioned tag, we are all in to make it tagged. |
This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this |
Description
switch oscam image to latest
⚒️ Fixes #
⚙️ Type of change
🧪 How Has This Been Tested?
📃 Notes:
✔️ Checklist:
feat(chart-name):
,fix(chart-name):
orchore(chart-name):
➕ App addition
If this PR is an app addition please make sure you have done the following.
icon.png
Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.