-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(openai): Add trace context to client requests #2321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ronensc! Great work :)
Left a small comment
): | ||
super().__init__() | ||
Config.enrich_assistant = enrich_assistant | ||
Config.enrich_token_usage = enrich_token_usage | ||
Config.exception_logger = exception_logger | ||
Config.get_common_metrics_attributes = get_common_metrics_attributes | ||
Config.upload_base64_image = upload_base64_image | ||
Config.disable_trace_context_propagation = disable_trace_context_propagation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think it's better to have "positive flags" - so this should be "enable_trace_context_propagation" and default to True
. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, no problem. done :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ronensc!
This PR resolves #2291.
A new flag,
enable_trace_context_propagation,
has been introduced to control trace context propagation. By default, this flag is set totrue
, ensuring that the trace context is propagated.feat(instrumentation): ...
orfix(instrumentation): ...
.