fix: navigation url to use summary #9696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
deboer-tim
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
All kubernetes path for a given resources need to specify which tab.. When I opened #9688 I thought we had some fallback or redirect, but we don't.
This PR adds
/summarysuffix to all routes. Here are the places where we use the router.goto, I will add #8294 to the next sprint.https://github.com/containers/podman-desktop/blob/d739ee969394f9065a3829c4b024415ee2c2abc7/packages/renderer/src/lib/service/ServiceColumnName.svelte#L9
https://github.com/containers/podman-desktop/blob/d739ee969394f9065a3829c4b024415ee2c2abc7/packages/renderer/src/lib/configmaps-secrets/ConfigMapSecretColumnName.svelte#L13
https://github.com/containers/podman-desktop/blob/d739ee969394f9065a3829c4b024415ee2c2abc7/packages/renderer/src/lib/deployments/DeploymentColumnName.svelte#L9
https://github.com/containers/podman-desktop/blob/d739ee969394f9065a3829c4b024415ee2c2abc7/packages/renderer/src/lib/ingresses-routes/IngressRouteColumnName.svelte#L13
https://github.com/containers/podman-desktop/blob/d739ee969394f9065a3829c4b024415ee2c2abc7/packages/renderer/src/lib/node/NodeColumnName.svelte#L9
https://github.com/containers/podman-desktop/blob/d739ee969394f9065a3829c4b024415ee2c2abc7/packages/renderer/src/lib/pvc/PVCColumnName.svelte#L9
https://github.com/containers/podman-desktop/blob/d739ee969394f9065a3829c4b024415ee2c2abc7/packages/renderer/src/lib/service/ServiceColumnName.svelte#L9
Screenshot / video of UI
What issues does this PR fix or reference?
How to test this PR?