Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(node/util): use string.split #15889

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

perf(node/util): use string.split #15889

wants to merge 3 commits into from
+17 −109

Conversation

DonIsaac
Copy link
Contributor

No description provided.

@DonIsaac DonIsaac added performance An issue with performance node:util labels Dec 20, 2024
@robobun
Copy link

robobun commented Dec 20, 2024 •
edited
Loading

Updated 10:03 PM PT - Dec 20th, 2024

❌ @DonIsaac, your commit c8fa6bc has 1 failures in #8388:

🧪   try this PR locally:

bunx bun-pr 15889

@DonIsaac DonIsaac marked this pull request as ready for review December 20, 2024 05:08
@DonIsaac DonIsaac added this pull request to the merge queue Dec 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2024
@DonIsaac @Jarred-Sumner
Update src/js/internal/util/inspect.js
c8fa6bc 
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarred-Sumner Jarred-Sumner Jarred-Sumner left review comments

Assignees
No one assigned
Labels
node:util performance An issue with performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DonIsaac @robobun @Jarred-Sumner