-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subprocess: fix crash when stdin outlives it #12983
base: main
Are you sure you want to change the base?
Conversation
Which test failure is this fixing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the crash is fixed, the Subprocess no longer uses the FileSink pointer, and the FileSink pointer no longer uses the Subprocess pointer
What is the purpose of having this shared pointer now?
Pulled out of changes for #11492, making separate patch to isolate against other test results, will rebase once merged. fixes crash reproducible on that branch on windows in
test/js/bun/spawn/spawn-streaming-stdin.test.ts
that occurred when Subprocess destroys itself before stdin does.