-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Revert store URL to material-ui.com/store #28365
Conversation
I guess we also need to not redirect material-ui.com/store to mui.com/store |
@oliviertassinari Do you know if something like this would work?
Besides, I'm also thinking about adding
|
This doesn't seem documented in https://docs.netlify.com/routing/redirects/. The safest would be to do it on a per subfolder basis. |
From what I read - https://docs.netlify.com/routing/redirects/#rule-processing-order, I think we need to add them in this order:
Would be great if we can test this first somehow. Maybe we can add temporary the URL from this PR deploy (https://deploy-preview-28365--material-ui.netlify.app/)? If this doesn't work, we can go safer and do what @oliviertassinari proposed by whitelisting the URLs per subfolder, namely creating entry for each of the items inside |
I'm afraid this would create a redirection loop. I listed all (hopefully) the subfolders individually. |
docs/public/_redirects
Outdated
https://material-ui.com/customization/* https://mui.com/customization/:splat 301! | ||
https://material-ui.com/guides/* https://mui.com/guides/:splat 301! | ||
https://material-ui.com/discover-more/* https://mui.com/discover-more/:splat 301! | ||
https://material-ui.com/company/* https://mui.com/company/:splat 301! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are missing the following entries:
https://material-ui.com/versions https://mui.com/versions 301!
Updated, the rest of the URLs didn't exist before
I could find only 1 missing, see #28365 (comment) |
docs/public/_redirects
Outdated
https://material-ui.com/getting-started/* https://mui.com/getting-started/:splat 301! | ||
https://material-ui.com/guides/* https://mui.com/guides/:splat 301! | ||
https://material-ui.com/performance/* https://mui.com/performance/:splat 301! | ||
https://material-ui.com/premium-themes/* https://mui.com/premium-themes/:splat 301! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This redirects currently to the store,we should handle it the same as the store.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 Thanks for taking this up!
I have added an item for it in #27825. @michaldudak thanks! |
Revert store links to the old domain.