Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Revert store URL to material-ui.com/store #28365

Merged
merged 6 commits into from
Sep 15, 2021

Conversation

michaldudak
Copy link
Member

Revert store links to the old domain.

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 15, 2021

No bundle size changes

Generated by 🚫 dangerJS against 4ab88ed

@oliviertassinari
Copy link
Member

I guess we also need to not redirect material-ui.com/store to mui.com/store

https://github.com/mui-org/material-ui/blob/5a0e7d9889e469b745a496aecbbf8b1c780c69f4/docs/public/_redirects#L14

@michaldudak
Copy link
Member Author

michaldudak commented Sep 15, 2021

@oliviertassinari Do you know if something like this would work?

https://material-ui.com/store/* /store/:splat 200!
https://material-ui.com/* https://mui.com/:splat 301!

Besides, I'm also thinking about adding

https://mui.com/store/* https://material-ui.com/store/:splat 302!

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 15, 2021

This doesn't seem documented in https://docs.netlify.com/routing/redirects/. The safest would be to do it on a per subfolder basis.

@mnajdova
Copy link
Member

From what I read - https://docs.netlify.com/routing/redirects/#rule-processing-order, I think we need to add them in this order:

https://material-ui.com/* https://mui.com/:splat 301!
https://mui.com/store/* https://material-ui.com/store/:splat 302!

Would be great if we can test this first somehow. Maybe we can add temporary the URL from this PR deploy (https://deploy-preview-28365--material-ui.netlify.app/)?

If this doesn't work, we can go safer and do what @oliviertassinari proposed by whitelisting the URLs per subfolder, namely creating entry for each of the items inside docs/pages

@michaldudak
Copy link
Member Author

From what I read - https://docs.netlify.com/routing/redirects/#rule-processing-order, I think we need to add them in this order:

https://material-ui.com/* https://mui.com/:splat 301!
https://mui.com/store/* https://material-ui.com/store/:splat 302!

I'm afraid this would create a redirection loop. I listed all (hopefully) the subfolders individually.

https://material-ui.com/customization/* https://mui.com/customization/:splat 301!
https://material-ui.com/guides/* https://mui.com/guides/:splat 301!
https://material-ui.com/discover-more/* https://mui.com/discover-more/:splat 301!
https://material-ui.com/company/* https://mui.com/company/:splat 301!
Copy link
Member

@mnajdova mnajdova Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing the following entries:

https://material-ui.com/versions https://mui.com/versions 301!

Updated, the rest of the URLs didn't exist before

@mnajdova
Copy link
Member

I could find only 1 missing, see #28365 (comment)

@michaldudak michaldudak added the website Pages that are not documentation-related, marketing-focused. label Sep 15, 2021
https://material-ui.com/getting-started/* https://mui.com/getting-started/:splat 301!
https://material-ui.com/guides/* https://mui.com/guides/:splat 301!
https://material-ui.com/performance/* https://mui.com/performance/:splat 301!
https://material-ui.com/premium-themes/* https://mui.com/premium-themes/:splat 301!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This redirects currently to the store,we should handle it the same as the store.

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 Thanks for taking this up!

@michaldudak michaldudak merged commit d9aed9c into mui:master Sep 15, 2021
@michaldudak michaldudak deleted the update-store-links branch September 15, 2021 17:11
@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 15, 2021

I have added an item for it in #27825. @michaldudak thanks!

@oliviertassinari oliviertassinari mentioned this pull request Sep 15, 2021
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants