Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Use https for material-ui & reactcommunity links #28304

Merged
merged 3 commits into from
Sep 14, 2021
Merged

[docs] Use https for material-ui & reactcommunity links #28304

merged 3 commits into from
Sep 14, 2021

Conversation

aghArdeshir
Copy link

@aghArdeshir aghArdeshir commented Sep 13, 2021 •
edited
Loading

Hi. I was reading the docs and clicked on a link and was redirected to http://reactcommunity.org and noted the website is not https. So I changed all the links to use https for reactcommunity and material-ui website.

Just please double check as my changes include:

  • CHANGELOG.old.md
  • md files in blog folder
  • docs with md format and api-docs with json format
  • package.json inside framer/Material-UI.framerfx folder
  • inside inline comments of js and .d.ts files

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 13, 2021 •
edited
Loading

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 7c000af

@eps1lon eps1lon changed the base branch from next to master September 14, 2021 08:35
eps1lon
eps1lon approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated, thanks! I reverted the changes to translated files since these are handled by Crowdin.

@github-actions github-actions bot mentioned this pull request Sep 14, 2021
Closed
@aghArdeshir
Copy link
Author

Thank you very much @eps1lon . That's very cool 👍

@eps1lon eps1lon merged commit c5215d1 into mui:master Sep 14, 2021
@aghArdeshir aghArdeshir deleted the http-to-https branch September 14, 2021 09:58
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aghArdeshir @mui-pr-bot @eps1lon @oliviertassinari