[website] Refine website before go-live #28081
Conversation
@oliviertassinari to fix this, I think it needs design change. I don't think it is worth the afford at this point. |
-title="MUI: A popular React UI framework"
+title="MUI: A popular React UI component library"@mbrookes are you sure? I have seen multiple places are using "framework". I don't have strong opinion, either word works for me. @oliviertassinari what's your thought? |
…ui into rebranding/polish-2
…ui into rebranding/polish-2
…ui into rebranding/polish-2
| @@ -18,7 +18,7 @@ export default function Pricing() { | |||
| return ( | |||
| <BrandingProvider> | |||
| <Head | |||
| title="Pricing - MUI" | |||
| title="MUI: Pricing" | |||
There was a problem hiding this comment.
Are we sure about this change? I'm asking because:
- When you have multiple tabs open, you have a limited space to display. The logo already allows differentiating MUI tabs from the other.
- On the docs page, we have
- MUI
- I used
title="MUI:on the homepage because it's the homepage 😁
There was a problem hiding this comment.
Ah, right. I guess {title} - MUI works fine too. I just had it changed to all pages so they are standardized. Only Pricing and About were following this pattern... But feel free to correct it!
| @@ -25,7 +25,7 @@ export default function AppFooter() { | |||
| gridAutoColumns: '1fr', | |||
| alignItems: 'center', | |||
| justifyContent: 'space-between', | |||
| gap: (theme) => theme.spacing(4, 2), | |||
| gap: (theme) => theme.spacing(4), | |||
There was a problem hiding this comment.
would have been simpler:
| gap: (theme) => theme.spacing(4), | |
| gap: 4, |
Final Webtest Result (on homepage): https://webpagetest.org/result/210915_BiDcG7_bd7e213b183b37e5cac8252ed9780392/1/details/
Suggestion from @oliviertassinari, We are getting closer to the release 🥁. I have noticed the following issues that we might want to fix:
The social sharing image is broken, and we likely don't have the visual yet.it is because the new image is not release yet, I think let's review the image instead. @mbrookes suggest that the tagline should change so this image should change too. @danilo-leal what do you think about adding "building" from matt's suggestion?https://cards-dev.twitter.com/validator
Something in [website] Refine home, pricing and about pages #27927 (comment) that I don't understand. @mbrookes please update my comment to clarify the problem and the change needed.@danilo-leal fixed it in that PR but it must have lost in code conflict in some PR. Anyway, fixed using danilo's code.@mui/materialin https://deploy-preview-28039--material-ui.netlify.app/?and
The structure here is a bit counter-intuitive, it's amay be later because it needs design change.button > div > a. It's not meant to be valid.Suggestion from @mbrookes
homepage titlefrom the discussion, go with "framework".There's something missing to balance with "solution". Solution to what problem? "building your UI" seems to be the problem statement. The alternative is to replace "solution" (or the whole phrase!) with something else...