Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one issue in test_stream.py #640

Open
mprib opened this issue Sep 15, 2024 · 1 comment
Open

Fix off-by-one issue in test_stream.py #640

mprib opened this issue Sep 15, 2024 · 1 comment
Assignees

Comments

@mprib
Copy link
Owner

mprib commented Sep 15, 2024

The frame_index is currently being updated prior to the pause loop. While this can be fixed for the test easily, the GUI appears to be coded to manage the auto-stop of the playback and the enablement/disablement of the buttons with this error in place.

I need to find the place(s) in the GUI code where this is happening and make sure that things will be triggered correctly when the frame_index is updating as it should.

@mprib
Copy link
Owner Author

mprib commented Sep 16, 2024

Just documenting for posterity that this test had been previously passing due to (I suspect) a lag in the processing and the frame index getting updated vs when it was checked. This did not become apparent until testing on MacOS via github actions and ran on windows just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant