# Fix dropping of partialAccepts

[marrej]

PartialAcceptances auto clear completions

repro in monaco env

TLDR: Issue with partially accepting characters that are already provided in the editor

Reproduction steps:

1. place cursor in given position -> def foo(ba)
2. type r
3. try to partially accept completion (2x to get out of the def brackets)

Expected result:
the completion is persisted on screen as it was partially accepted and the prefix doesn't diverge

Actual result:
The completion is dropped.

Reasoning:
From my investigation this happens due to the explicit signal of cursor position change with type api. This is not the case while the user partially accepts completions, with only ghosted text (not yet in the editor).

Suggestion:

• provide more comprehensive reason for position change, which should signal this is partialAcceptance/Acceptance and is a user trigger, not neccesarily an api OR update the onCursorChange to not trigger model.stop() when partialAccept is in progress (The earlier proposal might help in understanding what actually changes the position and there do not seem to be existing source === 'api' bindings, so no part of the system should be impacted)
• To keep the interaction consistent we might want to also change the setPosition on Accept, as there is already explicit cleanup happening after the edits are executed.