Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the deprecated canceled with Cancellation Error. #197605

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Replace the deprecated canceled with Cancellation Error. #197605

merged 2 commits into from
Dec 20, 2023

Conversation

shubhisroking
Copy link
Contributor

According to

vscode/src/vs/base/common/errors.ts

Line 180 in c97d74f

* @deprecated use {@link CancellationError `new CancellationError()`} instead

canceled is deprecated, So I replaced it with the recommendation

@shubhisroking
Replace the deprecated canceled with Cancellation Error.
2adf16a 
Signed-off-by: Shubh <shubhisroking@gmail.com>
@lszomoru lszomoru assigned joaomoreno and unassigned lszomoru Nov 7, 2023
@joaomoreno joaomoreno enabled auto-merge (squash) December 20, 2023 15:37
@joaomoreno
Copy link
Member

Thanks! 🍻

@joaomoreno joaomoreno added this to the December / January 2024 milestone Dec 20, 2023
@joaomoreno joaomoreno merged commit c963186 into microsoft:main Dec 20, 2023
6 checks passed
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@joaomoreno joaomoreno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shubhisroking @joaomoreno @TylerLeonhardt @lszomoru