fix: dialog is show when silent is true #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShowWindow(hwdn, SW_HIDE)
does not work for the dialog (DialogBoxParamW); to achieve silence, it can only be implemented throughEndDialog
.Since VSCode is relatively small in size, the dialog disappears quickly (around 200ms) during the upgrade process, so if you don't pay close attention, it goes unnoticed.
Reproduce video(at 6 seconds):
1.mp4
If you want to replicate it locally, you can replace the line
inno-updater/src/main.rs
Line 358 in 2732251
thread::sleep(std::time::Duration::from_millis(2000));
, and then execute: