Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define AgentEvent, rename tool call messages to events. #4750

Merged
merged 10 commits into from
Dec 18, 2024
Merged

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Dec 18, 2024

Resolves: #4533

@ekzhu ekzhu requested a review from victordibia December 18, 2024 07:17
@ekzhu
Copy link
Collaborator Author

ekzhu commented Dec 18, 2024

@gziz be aware of the changes in this PR, will affect what you are doing in #4719

Copy link
Contributor

@husseinmozannar husseinmozannar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about "Remove AgentMessage, always use union type ChatMessage | AgentEvent"

seems that union is used very often, maybe we just rename AgentMessage to "AgentChatMessage", I couldn't find a better name, so maybe we remove it cause there is no better name for it I guess..

@ekzhu
Copy link
Collaborator Author

ekzhu commented Dec 18, 2024

seems that union is used very often, maybe we just rename AgentMessage to "AgentChatMessage", I couldn't find a better name, so maybe we remove it cause there is no better name for it I guess..

My feeling is that by using separate types we are making it more explicit. Furthermore, the API documentation already expanded all possible types: https://microsoft.github.io/autogen/dev/reference/python/autogen_agentchat.ui.html

@ekzhu ekzhu merged commit e902e94 into main Dec 18, 2024
48 checks passed
@ekzhu ekzhu deleted the agent-event branch December 18, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AgentChat Event types
2 participants