Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rysweet 4679 move grpc to runtimegrpc project #4680

Merged
merged 29 commits into from
Dec 13, 2024

Conversation

rysweet
Copy link
Collaborator

@rysweet rysweet commented Dec 12, 2024

Why are these changes needed?

creating dependency separation of core from the services... will make testing and refactoring easier.

Related issue number

closes #4679

Checks

@rysweet rysweet added the dotnet issues related to AutoGen.Net label Dec 12, 2024
@rysweet rysweet added this to the 0.4.0 milestone Dec 12, 2024
@rysweet rysweet marked this pull request as draft December 12, 2024 08:16

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 51 out of 66 changed files in this pull request and generated no suggestions.

Files not reviewed (15)
  • dotnet/AutoGen.sln: Language not supported
  • dotnet/samples/Hello/HelloAIAgents/HelloAIAgents.csproj: Language not supported
  • dotnet/samples/Hello/HelloAgent/HelloAgent.csproj: Language not supported
  • dotnet/samples/Hello/HelloAgentState/HelloAgentState.csproj: Language not supported
  • dotnet/samples/dev-team/DevTeam.Agents/Developer/Developer.cs: Evaluated as low risk
  • dotnet/samples/Hello/HelloAgent/README.md: Evaluated as low risk
  • dotnet/samples/dev-team/DevTeam.Backend/Agents/AzureGenie.cs: Evaluated as low risk
  • dotnet/samples/Hello/protos/agent_events.proto: Evaluated as low risk
  • dotnet/samples/Hello/HelloAgentState/Program.cs: Evaluated as low risk
  • dotnet/samples/dev-team/DevTeam.Agents/ProductManager/ProductManager.cs: Evaluated as low risk
  • dotnet/samples/dev-team/DevTeam.Agents/DeveloperLead/DeveloperLead.cs: Evaluated as low risk
  • dotnet/samples/dev-team/DevTeam.Backend/Agents/Hubber.cs: Evaluated as low risk
  • README.md: Evaluated as low risk
  • dotnet/samples/dev-team/DevTeam.Backend/Services/GithubWebHookProcessor.cs: Evaluated as low risk
  • dotnet/samples/dev-team/DevTeam.Backend/Agents/Sandbox.cs: Evaluated as low risk
@rysweet rysweet marked this pull request as ready for review December 12, 2024 18:36
@lokitoth
Copy link
Member

lokitoth commented Dec 13, 2024

Looks good overall; I want to examine the idea to remove the IMessage dependency from Agent's PublishMessageAsync(), but I'll put that in a separate issue: #4695

@rysweet rysweet merged commit c169df8 into main Dec 13, 2024
49 checks passed
@rysweet rysweet deleted the rysweet-4679-move-grpc-to-runtimegrpc-project branch December 13, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet issues related to AutoGen.Net
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move GRPC services to Runtime.Grpc which depends only on Contracts
3 participants