-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rysweet 4679 move grpc to runtimegrpc project #4680
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rysweet
requested review from
lokitoth,
kostapetan,
LittleLittleCloud and
Copilot
December 12, 2024 08:16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 51 out of 66 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- dotnet/AutoGen.sln: Language not supported
- dotnet/samples/Hello/HelloAIAgents/HelloAIAgents.csproj: Language not supported
- dotnet/samples/Hello/HelloAgent/HelloAgent.csproj: Language not supported
- dotnet/samples/Hello/HelloAgentState/HelloAgentState.csproj: Language not supported
- dotnet/samples/dev-team/DevTeam.Agents/Developer/Developer.cs: Evaluated as low risk
- dotnet/samples/Hello/HelloAgent/README.md: Evaluated as low risk
- dotnet/samples/dev-team/DevTeam.Backend/Agents/AzureGenie.cs: Evaluated as low risk
- dotnet/samples/Hello/protos/agent_events.proto: Evaluated as low risk
- dotnet/samples/Hello/HelloAgentState/Program.cs: Evaluated as low risk
- dotnet/samples/dev-team/DevTeam.Agents/ProductManager/ProductManager.cs: Evaluated as low risk
- dotnet/samples/dev-team/DevTeam.Agents/DeveloperLead/DeveloperLead.cs: Evaluated as low risk
- dotnet/samples/dev-team/DevTeam.Backend/Agents/Hubber.cs: Evaluated as low risk
- README.md: Evaluated as low risk
- dotnet/samples/dev-team/DevTeam.Backend/Services/GithubWebHookProcessor.cs: Evaluated as low risk
- dotnet/samples/dev-team/DevTeam.Backend/Agents/Sandbox.cs: Evaluated as low risk
15 tasks
dotnet/src/Microsoft.AutoGen/Runtime.Grpc/Microsoft.AutoGen.Runtime.Grpc.csproj
Show resolved
Hide resolved
Looks good overall; I want to examine the idea to remove the IMessage dependency from Agent's PublishMessageAsync(), but I'll put that in a separate issue: #4695 |
lokitoth
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
creating dependency separation of core from the services... will make testing and refactoring easier.
Related issue number
closes #4679
Checks