Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add None back to remove_termination_string for a_resume in group chat #3410

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

heyitsaamir
Copy link
Collaborator

Why are these changes needed?

This looks like it was accidentally removed in #2804. Adding it back because it lead to some broken builds for us.

Related issue number

Checks

@marklysze
Copy link
Collaborator

Thanks @heyitsaamir, yep it does look like the None wasn't kept in the a_resume only in resume. Looks good to me.

@marklysze marklysze added the group chat/teams group-chat-related issues label Aug 24, 2024
@thinkall thinkall added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 30b79ae Aug 26, 2024
134 of 146 checks passed
@thinkall thinkall deleted the aamirj/fix_breaking_change branch August 26, 2024 07:13
victordibia pushed a commit that referenced this pull request Aug 28, 2024
Co-authored-by: Li Jiang <bnujli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group chat/teams group-chat-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants