Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] sign VideoConferenceProxyFilter_x86.dll artifact #13926

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

yuyoyuppe
Copy link
Contributor

Summary of the Pull Request

What is this about:

What is include in the PR:

How does someone test / validate:

Quality Checklist

  • Linked issue: #xxx
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yuyoyuppe yuyoyuppe merged commit 15f3c2f into microsoft:master Oct 20, 2021
@yuyoyuppe yuyoyuppe deleted the sign_vcm_x86 branch October 20, 2021 10:59
@gitkrasty
Copy link

image

Is this installator error somehow related?

@franky920920
Copy link
Contributor

@gitkrasty Please file your issue here. Thank you. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants