Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerToys Peek #36098

Open
kxng0109 opened this issue Nov 26, 2024 · 5 comments
Open

PowerToys Peek #36098

kxng0109 opened this issue Nov 26, 2024 · 5 comments
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Issue-Bug Something isn't working Product-Peek Refers to Peek Powertoys Status-In progress This issue or work-item is under development Status-Reproducible This issue was reproduced by a maintainer

Comments

@kxng0109
Copy link

Microsoft PowerToys version

0.86.0

Installation method

Microsoft Store, PowerToys auto-update

Running as admin

No

Area(s) with issue?

Peek

Steps to reproduce

  • Open a file using Peek (ctrl + space)
  • Minimize the file
  • Select another file and open the file using Peek

✔️ Expected Behavior

I expected peek to un-minimize itself and show the file I opened.

❌ Actual Behavior

Instead it seems to stay minimized until I open it from my taskbar. I'm not sure if this is considered a bug, but usually when you open a file in an app, the app will "un-minimize" to show the file you opened using the app. But peek doesnt seem to do so.

Other Software

No response

@kxng0109 kxng0109 added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Nov 26, 2024
Copy link

We've found some similar issues:

If any of the above are duplicates, please consider closing this issue out and adding additional context in the original issue.

Note: You can give me feedback by 👍 or 👎 this comment.

@davidegiacometti davidegiacometti added Help Wanted We encourage anyone to jump in on these and submit a PR. Product-Peek Refers to Peek Powertoys labels Nov 27, 2024
@github-project-automation github-project-automation bot moved this to ⚠️Needs Walkthrough in 3. Help Wanted Nov 27, 2024
@davidegiacometti davidegiacometti added Status-Reproducible This issue was reproduced by a maintainer and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Nov 27, 2024
@davidegiacometti
Copy link
Collaborator

Hi, I think it makes sense to restore the minimized window.

This is the current behavior when Peek is in background (not minimized) and Explorer in foreground, press Peek shortcut on another file, Peek is brought in foreground. Minimized should act the same.

@htcfreek
Copy link
Collaborator

@asif4318
Your contribution is welcome and thank you for your work on this. Feel free to open a PR. If you have any further questions don't worry to ask them.

@htcfreek htcfreek added the Status-In progress This issue or work-item is under development label Dec 21, 2024
@asif4318
Copy link

I just took a deeper look at this issue.

If the peek shortcut is applied to another file while an existing peek window is minimized, the minimized window appropriately previews the new file. However, this minimized window is not brought into the foreground. Pressing the peek shortcut again closes the preview window entirely.

My plan to rectify this is to check if an existing Peek.UI window exists and if it does, bring that window into the foreground.

asif4318 added a commit to asif4318/PowerToys that referenced this issue Dec 22, 2024
… allows the UI to be presented even if it was previously minimized. Solves microsoft#36098.
@asif4318
Copy link

Took me a minute to understand how the Peek module works due to the lack of documentation. Once I understood it, this was a simple one line addition.

I would like guidance to see if an automated test could be added to test the new behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Issue-Bug Something isn't working Product-Peek Refers to Peek Powertoys Status-In progress This issue or work-item is under development Status-Reproducible This issue was reproduced by a maintainer
Projects
Status: ⚠️Needs Walkthrough
Development

No branches or pull requests

4 participants