[C#] Add StorageDeviceBase.OmitSegmentIdFromFilename #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for implementors)
badrishc
approved these changes
Apr 21, 2023
badrishc
reviewed
Apr 21, 2023
| @@ -53,7 +53,7 @@ public TieredStorageDevice(int commitPoint, params IDevice[] devices) : this(com | |||
| { | |||
| } | |||
|
|
|||
| public override void Initialize(long segmentSize, LightEpoch epoch) | |||
| public override void Initialize(long segmentSize, LightEpoch epoch, bool omitSegmentIdFromFileName = false) | |||
| { | |||
| base.Initialize(segmentSize, epoch); | |||
There was a problem hiding this comment.
call base with omitSegmentIdFromFileName
badrishc
reviewed
Apr 21, 2023
| /// </summary> | ||
| /// <param name="segmentSize"></param> | ||
| /// <param name="epoch"></param> | ||
| public override void Initialize(long segmentSize, LightEpoch epoch) | ||
| /// <param name="omitSegmentIdFromFileName"></param> | ||
| public override void Initialize(long segmentSize, LightEpoch epoch, bool omitSegmentIdFromFileName = false) | ||
| { | ||
| base.Initialize(segmentSize, epoch); |
There was a problem hiding this comment.
Call base.Initialize with omitSegmentIdFromFileName
badrishc
reviewed
Apr 21, 2023
cs/test/TestUtils.cs
Outdated
| @@ -138,19 +138,20 @@ internal static IDevice CreateTestDevice(DeviceType testDeviceType, string filen | |||
| #if NETSTANDARD || NET | |||
| if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) // avoids CA1416 // Validate platform compatibility | |||
| #endif | |||
| device = new LocalStorageDevice(filename, preallocateFile, deleteOnClose, disableFileBuffering, capacity, recoverDevice, useIoCompletionPort); | |||
| device = new LocalStorageDevice(filename, preallocateFile, deleteOnClose, disableFileBuffering, capacity, recoverDevice, useIoCompletionPort, omitSegmentIdFromFilename: omitSegmentIdFromFilename); | |||
There was a problem hiding this comment.
why is omitSegmentIdFromFileName is both constructor and Initialize? which one take precedence if they put true in contructor and omit (default false) in the Initialize.
badrishc
approved these changes
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.