Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing multiple type definition issue and fixing NotifyCollectionChangedAction issue #1816

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

manodasanW
Copy link
Member

  • The WebView package and the WinAppSDK 1.5 package both can be referenced by someone and have the same types defined in both. One is an RCW generated by CsWinRT while the other is not as it is for netcore3. Our RCW fallback generator tries to make the WinAppSDK version of it trimming safe but given it is defined in multiple places that leads to a compiler error. It would also be a compiler error already if the component itself tried to use that type. So instead of letting them become a compiler error, we just emit a warning / info to call out we weren't able to make it trim safe and the user should update versions if they need that.
  • NotifyCollectionChangedAction wasn't marked as blittable when it should have been as seen in Error CS0122: 'NotifyCollectionChangedAction' is inaccessible due to its protection level #1813

@manodasanW manodasanW merged commit ec94cc7 into master Oct 10, 2024
10 checks passed
@manodasanW manodasanW deleted the manodasanw/webviewmultipleinstances branch October 10, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants