fix: set json loads strict to false #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b59f9c5 to
e5d6ccf
Compare
this avoids errors based on control characters within message json
e5d6ccf to
000c8f9
Compare
cpacker
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Thanks for this @tombedor , LGTM!
Backlinking #800 (comment) for later reference.
@tombedor - do you mind adding (also for future reference) an example stdout log where prior to this change an error is thrown? (basically just illustrating an example sequence that this PR fixes)
norton120
pushed a commit
to norton120/MemGPT
that referenced
this pull request
Feb 15, 2024
mattzh72
pushed a commit
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this avoids errors based on control characters within message json
also where relevant, remove unused imports