Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fixes #3434

Merged
merged 1 commit into from
Oct 17, 2017
Merged

minor fixes #3434

merged 1 commit into from
Oct 17, 2017

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Oct 17, 2017

No description provided.

rpetrusha
rpetrusha approved these changes Oct 17, 2017
View reviewed changes
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've made parallel changes in microsoft/dotnet.
This is ready to merge, @mairaw .

@rpetrusha
Copy link
Contributor

@conniey, for some reason, some of the text at the end of the suggestion section in the file on microsoft/dotnet was not migrated to this file.

@rpetrusha rpetrusha mentioned this pull request Oct 17, 2017
Merged
@mairaw mairaw merged commit 8074fb4 into dotnet:master Oct 17, 2017
@mairaw mairaw deleted the mairaw-patch-2 branch October 17, 2017 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpetrusha rpetrusha rpetrusha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mairaw @rpetrusha @dnfclas