Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/arcade #48357

Merged
merged 10 commits into from
Jun 14, 2023
Merged

[main] Update dependencies from dotnet/arcade #48357

merged 10 commits into from
Jun 14, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 22, 2023 •
edited
Loading

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.SourceLink.GitHub: from 8.0.0-beta.23218.3 to 8.0.0-beta.23309.3 (parent: Microsoft.DotNet.Arcade.Sdk)

From https://github.com/dotnet/arcade

  • Subscription: 89b8d7af-c2e7-42f8-3b29-08d8b8050dda
  • Build: 20230612.4
  • Date Produced: June 12, 2023 7:03:18 PM UTC
  • Commit: f3952775e6d00a5b6f43b0615a8a766e095185eb
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
a0c50cd 
…519.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor
 From Version 8.0.0-beta.23262.5 -> To Version 8.0.0-beta.23269.2

Dependency coherency updates

Microsoft.SourceLink.GitHub
 From Version 8.0.0-beta.23218.3 -> To Version 8.0.0-beta.23252.2 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro dotnet-maestro bot requested review from a team and wtgodbe as code owners May 22, 2023 12:09
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 22, 2023
ghost
ghost approved these changes May 22, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@ghost
Copy link

ghost commented May 22, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@javiercn
Copy link
Member

@wtgodbe do you have any idea of what's going on here?

@wtgodbe
Copy link
Member

wtgodbe commented May 24, 2023

I'm guessing sourcelink just got moved out of Arcade/into the SDK? @ViktorHofer how do we need to react here?

@ViktorHofer
Copy link
Member

ViktorHofer commented May 24, 2023 •
edited
Loading

I'm guessing sourcelink just got moved out of Arcade/into the SDK? @ViktorHofer how do we need to react here?

@tmat is driving that change. Tomas, can you please help?

@tmat
Copy link
Member

tmat commented May 26, 2023

Should be fixed by dotnet/sourcelink#1034

@wtgodbe
Copy link
Member

wtgodbe commented May 26, 2023

Just triggered a manual update

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
44cfc5a 
…525.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor
 From Version 8.0.0-beta.23262.5 -> To Version 8.0.0-beta.23275.2

Dependency coherency updates

Microsoft.SourceLink.GitHub
 From Version 8.0.0-beta.23218.3 -> To Version 8.0.0-beta.23252.2 (parent: Microsoft.DotNet.Arcade.Sdk
@wtgodbe
Copy link
Member

wtgodbe commented May 26, 2023 •
edited
Loading

@tmat we're still seeing

D:\a\_work\1\s\.dotnet\sdk\8.0.100-preview.5.23257.1\Sdks\Microsoft.Build.Tasks.Git\build\Microsoft.Build.Tasks.Git.targets(49,5): error : SourceLink: Repository instance not found in cache: 'local:D:\a\_work\1\s\.git' [D:\a\_work\1\s\artifacts\bin\trimmingTests\projects\Microsoft.AspNetCore.NativeAotTests\UseStartupThrowsForStructContainersTest\project.csproj]

@tmat
Copy link
Member

tmat commented May 26, 2023 •
edited
Loading

Did the Source Link change flow into SDK 8.0.100-preview.5.23257.1?

@wtgodbe
Copy link
Member

wtgodbe commented May 26, 2023

Did the Source Link change flow into SDK 8.0.100-preview.5.23257.1?

No, that SDK is from a couple weeks ago. Do we need an SDK with the arcade update before we can ingest the arcade update here?

@tmat
Copy link
Member

tmat commented May 26, 2023

Yes, you'd need the SDK that has Source Link with that change

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
bce3b77 
…529.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor
 From Version 8.0.0-beta.23262.5 -> To Version 8.0.0-beta.23279.1

Dependency coherency updates

Microsoft.SourceLink.GitHub
 From Version 8.0.0-beta.23218.3 -> To Version 8.0.0-beta.23252.2 (parent: Microsoft.DotNet.Arcade.Sdk
@mitchdenny
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

sebastienros and others added 5 commits June 1, 2023 11:17
@sebastienros
Update SDK
266dc39
@sebastienros
Merge branch 'main' into darc-main-2268b52a-c46f-4b5a-aba3-b9fe92bca32f
8c2d19a
@sebastienros
Update global.json
1d55e4d
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
4039290 
…602.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor
 From Version 8.0.0-beta.23262.5 -> To Version 8.0.0-beta.23302.3

Dependency coherency updates

Microsoft.SourceLink.GitHub
 From Version 8.0.0-beta.23218.3 -> To Version 8.0.0-beta.23252.2 (parent: Microsoft.DotNet.Arcade.Sdk
@eerhardt
Merge remote-tracking branch 'upstream/main' into darc-main-2268b52a-…
2b50c35 
…c46f-4b5a-aba3-b9fe92bca32f
@eerhardt
Copy link
Member

eerhardt commented Jun 7, 2023

@tmat - we are still getting the same error. The SDK being used in aspnetcore is from yesterday. Do we know what the issue is here?

@JamesNK
Copy link
Member

JamesNK commented Jun 9, 2023

@tmat Can you provide us with an update? Dependencies are further behind than they should be.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
afacc05 
…609.8

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor
 From Version 8.0.0-beta.23262.5 -> To Version 8.0.0-beta.23309.8

Dependency coherency updates

Microsoft.SourceLink.GitHub
 From Version 8.0.0-beta.23218.3 -> To Version 8.0.0-beta.23252.2 (parent: Microsoft.DotNet.Arcade.Sdk
@amcasey amcasey mentioned this pull request Jun 12, 2023
Merged
@BrennanConroy
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
2f0b3a1 
…612.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor
 From Version 8.0.0-beta.23262.5 -> To Version 8.0.0-beta.23312.4

Dependency coherency updates

Microsoft.SourceLink.GitHub
 From Version 8.0.0-beta.23218.3 -> To Version 8.0.0-beta.23309.3 (parent: Microsoft.DotNet.Arcade.Sdk
@BrennanConroy BrennanConroy enabled auto-merge (squash) June 13, 2023 23:43
@BrennanConroy BrennanConroy merged commit 8708726 into main Jun 14, 2023
@BrennanConroy BrennanConroy deleted the darc-main-2268b52a-c46f-4b5a-aba3-b9fe92bca32f branch June 14, 2023 00:19
@ghost ghost added this to the 8.0-preview6 milestone Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Milestone
8.0-preview6
Development

Successfully merging this pull request may close these issues.
9 participants
@javiercn @wtgodbe @ViktorHofer @tmat @mitchdenny @eerhardt @JamesNK @BrennanConroy @sebastienros