Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share button on local extension page and marketplace #233915

Closed
altsang opened this issue Nov 15, 2024 · 10 comments
Closed

share button on local extension page and marketplace #233915

altsang opened this issue Nov 15, 2024 · 10 comments
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@altsang
Copy link

altsang commented Nov 15, 2024

Many times a user may want to share an extension they are using quickly by sending someone a link. It's easier to generate and find such link on the extension page itself in all the locations accessible including the extensions installed on one's local installation in addition to the marketplace. Suggest adding a share button that generates a URL link that can be posted easily that links to the extension's listing in the marketpalce

@altsang
Copy link
Author

altsang commented Nov 15, 2024

mentioning @isidorn for viz too

@isidorn isidorn added the extensions Issues concerning extensions label Nov 18, 2024
@isidorn
Copy link
Contributor

isidorn commented Nov 18, 2024

I like this suggestion by @altsang
The open question is where would this Share button / action show up in the UI? We could add it to the Extension Details -> Context Menu. Any better ideas?

@sandy081 would you be open to a PR from the community that adds this?

@sandy081
Copy link
Member

Very much

@sandy081 sandy081 added the feature-request Request for new features or functionality label Nov 18, 2024
@sandy081 sandy081 added this to the Backlog milestone Nov 18, 2024
@isidorn isidorn added the good first issue Issues identified as good for first-time contributors label Nov 18, 2024
@shinyumh
Copy link

Hello! Can I try working on this? I would also appreciate any resources on how to get started with implementation. Thank you!

@cachandlerdev
Copy link
Contributor

Depending on whether anybody gets to this over the next few days, I could also try to contribute by this weekend after my CS midterms are over.

@Hasteerp
Copy link

Hey @isidorn,

I could start working on it right away! Please assign the issue to me. Thanks!

@isidorn
Copy link
Contributor

isidorn commented Nov 19, 2024

Thank you for your interest. Let's first figure out what the solution is, before we start coding.
For example where do you think the Share button should actually appear and how?

We do not assign issues to outside contributors. It will remain assigned to Sandeep, and once there is a PR that solves this issue in a good way we will work on merging it in.

@aslezar
Copy link
Contributor

aslezar commented Nov 19, 2024

Image
I recommend adding it here after the copy extension ID, "Copy Marketplace Link". Will it work for us?

@SalerSimo
Copy link

@isidorn @aslezar there might be an issue: some extensions(like built-in ones) are not listed on the marketplace, so copying a 'marketplace link' would be pointless.

@sandy081 sandy081 added the author-verification-requested Issues potentially verifiable by issue author label Dec 2, 2024
@sandy081
Copy link
Member

sandy081 commented Dec 2, 2024

To Verify:

Verify that there is a Copy Link action in the context menu of the extension and it copies the extension's marketplace link.

@sandy081 sandy081 added verification-needed Verification of issue is requested and removed author-verification-requested Issues potentially verifiable by issue author labels Dec 2, 2024
@alexr00 alexr00 added the verified Verification succeeded label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

9 participants