Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find My Mouse Spotlight Transparency #15512

Open
ZackPlauche opened this issue Jan 13, 2022 · 29 comments
Open

Find My Mouse Spotlight Transparency #15512

ZackPlauche opened this issue Jan 13, 2022 · 29 comments
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-Mouse Utilities Refers to the Mouse Utilities PowerToy Product-Settings The standalone PowerToys Settings application

Comments

@ZackPlauche
Copy link

Description of the new feature / enhancement

This is likely already requested, but why not just make the spotlight area transparent instead of white?

There's no setting to change the color opacity here.

We ideally are able to just make the content we want to highlight transparent and visible instead of lighter and hard to see. Let's make it transparent 🙂.

Scenario when this would be used?

This is important to ensure that you're able to see whatever you're highlighting or focusing on in general.

Supporting information

Just make it a slider to add color transparency, or alpha values on the color itself.

@ZackPlauche ZackPlauche added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jan 13, 2022
@Aaron-Junker Aaron-Junker added Product-Mouse Utilities Refers to the Mouse Utilities PowerToy Idea-Enhancement New feature or request on an existing product labels Jan 13, 2022
@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jan 13, 2022
@crutkas
Copy link
Member

crutkas commented Jan 13, 2022

this may be as easy as adding these to the color picker control.

  IsAlphaEnabled="True"
  IsAlphaSliderVisible="True"
  IsAlphaTextInputVisible="True"

@Jay-o-Way Jay-o-Way added the Product-Settings The standalone PowerToys Settings application label Jan 14, 2022
@BhargaviAnnadevara
Copy link

@crutkas +1 to this request. Is this in the pipeline?

@woshitoutouge
Copy link

+1

@franky920920
Copy link
Contributor

@crutkas +1 to this request. Is this in the pipeline?

Not yet, I think. PR is welcome :D

@DaniW42
Copy link

DaniW42 commented Mar 6, 2022

Just saw that a 100% overlay ends up with even the spotlight being 100% white without any background being visible. Maybe another transparency slider for the spotlight would make it most customizable?

@woshitoutouge
Copy link

woshitoutouge commented Mar 11, 2022

image

please add the color transparency, so it's not only "find my mouse", but can also be used as "find the mouse" for youtuber and the audience

@mimhufford
Copy link

I had a go at modifying the source a few weeks back but couldn't find a simple solution.

In the mean time I whipped up a standalone solution which people are free to use here:
https://github.com/mimhufford/mouse

@jaimecbernardo
Copy link
Collaborator

I had a go at modifying the source a few weeks back but couldn't find a simple solution.

In the mean time I whipped up a standalone solution which people are free to use here: https://github.com/mimhufford/mouse

Nice. Thanks for sharing!
Can you please explain this detail here?
https://github.com/mimhufford/mouse/blob/5c69a6e8b30e8e0bcd0254a2d07520713879ff16/mouse.cpp#L47

@mimhufford
Copy link

I'm honestly not sure, it relates to this comment at the top of the document. For some reason if the width and height of the window is the exact resolution of your monitor then transparency doesn't work at all. Adding 1 to the height is a simple workaround that doesn't seem to have any negative side effects, so I just went for it in order to keep moving forwards.

@Jay-o-Way
Copy link
Collaborator

Or - in stead of adding more and more settings - we could just choose to keep the spotlight tranparent. Period?

@woshitoutouge
Copy link

woshitoutouge commented Oct 11, 2022 via email

@Jay-o-Way
Copy link
Collaborator

@crutkas your idea for the alpha slider is simple and sensible. Does it need any changes in the code to work correctly? Does the idea need any more second opinions?

@nabazgharib
Copy link

I hope you work on the feature, just make the spotlight transparent.
I am checking the versions, unfortunately you keep pushing this feature from one version to another version.

@Denyerec
Copy link

Denyerec commented Jul 4, 2024

I hope you work on the feature, just make the spotlight transparent. I am checking the versions, unfortunately you keep pushing this feature from one version to another version.

#15512 (comment)

Indeed. I think this is on the "Never gonna happen" list, despite it being both simple and super useful :(

@nabazgharib
Copy link

@jaimecbernardo I am just wondering if this feature is so difficult to be implemented that takes you keep pushing it from one version to another version? if you already planned to dismiss this requested feature, you could have just simply said it will not be added.

@jaimecbernardo
Copy link
Collaborator

It's tagged as Help Wanted, meaning it'd be good for someone in the community to pick up. 😄
Still want to keep track of it in case there's some time for someone in the team to pick it up, but new priorities keep appearing. 🤷
Sorry for the delay.

@nabazgharib
Copy link

Thanks,
I hope it will be added in the next release.

@Denyerec
Copy link

Pushed out further than the Star Citizen release date... :(

@nabazgharib
Copy link

Such an easy, my be, fixed by a one line of code is pushed way too far.
I would say it is better to say we don't do it, then delete it.

@Jay-o-Way
Copy link
Collaborator

Such an easy, my be, fixed by a one line of code is pushed way too far.
I would say it is better to say we don't do it, then delete it.

Go and send in a pull request then

@Denyerec
Copy link

Denyerec commented Oct 4, 2024

https://github.com/microsoft/PowerToys/blob/e7175302c9226d7fab8ef3d9271abd188758ffbb/src/modules/MouseUtils/FindMyMouse/FindMyMouse.cpp#L720C46-L720C62

Here's the line. It takes a Color struct which supports Alpha.

I don't know much about Windows Dev, in fact nothing at all, but it feels like if the colour picker in the settings allowed an alpha to be specified, it'd "Just Work".

Would love to be corrected by someone who knows better, as I'm genuinely curious and have a huge potential for ignorance.

@nabazgharib
Copy link

https://github.com/microsoft/PowerToys/blob/e7175302c9226d7fab8ef3d9271abd188758ffbb/src/modules/MouseUtils/FindMyMouse/FindMyMouse.cpp#L720C46-L720C62

Here's the line. It takes a Color struct which supports Alpha.

I don't know much about Windows Dev, in fact nothing at all, but it feels like if the colour picker in the settings allowed an alpha to be specified, it'd "Just Work".

Would love to be corrected by someone who knows better, as I'm genuinely curious and have a huge potential for ignorance.

@Jay-o-Way

@rohanhare
Copy link

+1
My $0.02 isn't anything you haven't heard before, but wanted to show my support.

Leaving the spotlight on for a few moments makes the spotlighted content almost harder to see. 100% transparency would really focus your eye on the spotlighted content.

@Denyerec
Copy link

Coming up for 3 years now :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-Mouse Utilities Refers to the Mouse Utilities PowerToy Product-Settings The standalone PowerToys Settings application
Projects
Status: No status
Status: No status
Status: To do
Development

No branches or pull requests