[PT Run] Disabling shell plugins does not work

[cory-chang]

Microsoft PowerToys version

0.33.1

Running as admin

Yes

Area(s) with issue?

PowerToys Run

Other Software

No response

Steps to reproduce

1. Turn off "Shell" under Plugins in PT Run
2. Type in a command, such as "ping"
3. See results for the executing the command ping

✔️ Expected Behavior

Nothing to show up, because I have disabled executing shell commands from PT Run

❌ Actual Behavior

I see commands show up, see screenshot below

[enricogior]

@ccory2004
this is expected, the result is returned by the program plugin.

[cory-chang]

@enricogior Hm, I guess that makes sense, but I think the disabling shell commands should really disable anything run in the shell, like ping. Do you know if there is a way to differentiate between gui programs and cli programs?

[htcfreek]

@ccory2004

Hm, I guess that makes sense, but I think the disabling shell commands should really disable anything run in the shell, like ping.

What is the use case/reason for this?

[cory-chang]

@htcfreek Its mostly just stylistic, I use PT Run mainly for apps that I use on a daily basis and files, and the commands get in the way of it sometimes.

But I do think it is a bit misleading (if understandable) that disabling shell doesn't actually disable most commands, which makes the option not super useful. Maybe part of it has to do with the examples that are given in the description (ping and cmd), both of which still appear even after disabling them, as well as the wording underneath them still reads "Run command", which really references the idea of executing a shell command, as opposed to applications that show "Application" below them.

Also, forgive my ignorance, but I wasn't able to come up with a single command that no longer works with the Shell plugin turned off, but maybe I'm missing something.

Sorry for the long-ish response.